Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Hex instead of ASCII #6

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

robertmin1
Copy link
Contributor

@robertmin1 robertmin1 commented May 14, 2024

This will allow us to parse CBOR and face fewer bugs.

  • It appears that Electrum-NMC has a bug when handling options arguments, as it passes them in the name_encoding field instead of the options field.
  • A simple temporary fix I used is:
if type(name_encoding) is dict:
   options = name_encoding

here

Fixes #2

@JeremyRand
Copy link
Member

CI is flagging a nil pointer dereference, can you fix that?

@robertmin1 robertmin1 force-pushed the master branch 2 times, most recently from faa252b to ec42d45 Compare May 15, 2024 04:04
@robertmin1
Copy link
Contributor Author

robertmin1 commented May 15, 2024

Fixed, we can also set options if it's nil

@JeremyRand
Copy link
Member

Fixed, we can also set options if it's nil

Yes please do that.

names.go Outdated Show resolved Hide resolved
names.go Outdated Show resolved Hide resolved
@robertmin1
Copy link
Contributor Author

robertmin1 commented May 15, 2024

Looks like I was wrong, that fixed it (Tried gci not sure why it didn't work)

Use HEX instead of ASCII
@JeremyRand
Copy link
Member

ACK a1a0b77

@JeremyRand JeremyRand merged commit e1fd9e1 into namecoin:master May 15, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to hex encoding after old Namecoin Core is phased out
2 participants