Explicitly set header in JWS::load #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the constructor, the header is ordered in its own order, not according to how the provided token may ahve be ordered. This then causes signature validation to fail because the header has been reordered from what the original token provided.
|
Thanks dude! :) Would you be able to add a test case as well? |
|
Alrighty. There ya go! I tried to match it up with the other test cases that were there, but feel free to modify it however needed. |
|
yay! thanks man! |
odino
added a commit
that referenced
this pull request
Apr 13, 2015
Explicitly set header in JWS::load
|
there in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the constructor, the header is ordered in its own order, not according to how the provided token may have be ordered. This then causes signature validation to fail because the header has been reordered from what the original token provided.
Example: My token is created by another service that puts the header in order of [typ, alg]. When JWS::load is used, when the JWS token's constructor is used, it always orders it [alg, typ]. This, now reordered header, is then later json encoded and used in the signature verification, which of course will now fail.
By setting the header to what the token provided, signature verification can now succeed, regardless of the order of the json fields.