CS Fixes and simplifed SecLib signers #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @kbond would you be able to send 2 separate PRs for the cs fixes and the other stuff? It makes it easy to merge just the cs stuff and then discuss the rest :) cheers! |
|
closing for now |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the codebase through php-cs-fixer to clean up some stuff.
I also simplified the SecLib Signers. My guess is you were planning on adding more algorithms to SecLib later so the
PublicKeylevel I removed may be necessary if this happens. I can revert this if you'd like.A few questions/comments I had while going through the codebase:
SignerInterfaceis suffixed with interface whileEncoderis not. I suggest standardizing on one way.require-dev.