Update phpseclib dependency to 2.0 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thanks a bunch man! I think the failures were a temporary glitch, gonna merge now! |
odino
added a commit
that referenced
this pull request
Oct 19, 2015
Update phpseclib dependency to 2.0
|
@thijsvdanker sorry but I had to rollback to phpseclib 1.0. Version 2.0 seems to have issues with the current codebase. At the moment version 1.0 is not supported by PHP7. I would like to include phpseclib 2.0, but before merging it again we need more automated tests. Feel free to send another PR :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a stable version of phpseclib, so I guess it would make sense to move from 0.3 to 2.0.
There are 3 tests failing, but they are also failing on the master branch so I think they're not related to this update.