This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
mysqliに変更 #33
Merged
mysqliに変更 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
こちらのテストで落ちてる部分は、僕のプルリクで直る内容と思われます。 |
|
ありがとうございます！ |
|
おかげさまで、 PHP7 でテスト通るようになりました！ |
|
phpunitが No tests executed! ってなるのはなんでなんでしょうね？ |
|
あ、ほんとですね。 PHP7 でパスの指定がちょっと変わってるかもしれないので見てみます |
|
php vendor/bin/phpunit に変えれば動きそうな気もします |
|
手元の MySQL 5.7.17 な環境だと |
|
sql_mode が原因でdateのdefaultが変わったので怒られますよ |
|
あーなるほど |
|
@nobuhiko php vendor/bin/phpunit で PHP7 までは通るようになりました。 https://travis-ci.org/nanasess/ec-cube-extended/builds/232748571 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP7でもtravisが動くようになりましたが、テストは動いてない模様