Take Rouge class from pre rather than code #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rouge’s HTML formatter was changed so that the class appears on the `pre` element rather than the `code` element. See also rouge-ruby/rouge#191.
Closed
|
don't we need to change some dependencies so proper gem version of Rouge is used? |
|
There’s no dependency on Rouge anywhere; it is loaded whenever rouge is used in the It’s not ideal, but that’s how it is. |
|
just an idea, what if it was extracted to separate gem/plugin and then we coudl define the dependency in it. |
|
That’s what the nanoc 4.x work is about (although it’s been pretty quiet on that front lately). |
|
I will be happy to help with |
|
Can I get a +1? |
|
👍 it matches the mentioned ticket |
Merged
denisdefreyne
added a commit
that referenced
this pull request
Dec 6, 2014
Take Rouge class from pre rather than code
Closed
denisdefreyne
added a commit
that referenced
this pull request
Jan 4, 2015
7 tasks
denisdefreyne
added a commit
that referenced
this pull request
Jan 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rouge’s HTML formatter was changed so that the class appears on the
preelement rather than thecodeelement.See also rouge-ruby/rouge#191.