Skip to content

Add support for custom attributes with constructors for methods and classes #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

Add support for custom attributes with constructors for methods and classes #102

merged 1 commit into from
Apr 27, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Apr 25, 2020 •
edited
Loading

Description

  • Rework existing GetCustomAttributes for FieldInfo to follow DRY.
  • Bump AssemblyNativeVersion to v100.4.8.0.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Add support for custom attributes with constructors for methods and a…
2221f5c 
…nd classes

- Rework existing GetCustomAttributes for FieldInfo to follow DRY.
- Bump AssemblyNativeVersion to v100.4.8.0.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Apr 25, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Apr 25, 2020
@josesimoes
Add support for custom attributes with constructors for classes and m…
621eec0 
…ethods

- Rework existing code in FieldInfo to follow DRY.
- Update mscorlib assembly declaration.
- Follows nanoframework/CoreLibrary#102.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Apr 25, 2020
Merged
10 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josesimoes josesimoes merged commit eb5e32c into nanoframework:develop Apr 27, 2020
@josesimoes josesimoes deleted the add-attr-with-const-method-types branch April 27, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI: Publish Release CI: Update Dependents Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetCustomAttributes not working
2 participants
@josesimoes @nfbot