Skip to content

Conversation

MatthiasJentsch
Copy link
Contributor

Description

The check for appending zeros was not correct

Motivation and Context

How Has This Been Tested?

With the fix no additional zeros are added

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Matthias Jentsch info@matthias-jentsch.de

@nfbot
Copy link
Member

nfbot commented Nov 19, 2018

Hi @MatthiasJentsch,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix. 👍

@josesimoes josesimoes changed the title Fix for issue #406 Fix ToString() output Nov 19, 2018
@josesimoes josesimoes merged commit 35f62a9 into nanoframework:develop Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

double.ToString() and float.ToString() not working as described

3 participants