Skip to content

Conversation

KlausVcb
Copy link
Contributor

@KlausVcb KlausVcb commented Mar 7, 2022

Description

The HttpResponseMessage.StatusCode was not exposed through it's backing field.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Klaus Vancamelbeke added 2 commits March 7, 2022 10:28
The HttpResponseMessage.StatusCode was not exposed through it's backing field.

Signed-off-by: Klaus Vancamelbeke (klaus@proles.be)
Explained about using a proxy to let a MCU connect to a development machine running IIS Express. Also warned about SocketExceptions that occur but can be countered with a retry mechanism.

Signed-off-by: Klaus Vancamelbeke (klaus@proles.be)
- Remove extra line.
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please split the readme update on the separate PR?
We prefer to have PRs "atomic" and addring a single issue. 😉

@KlausVcb KlausVcb changed the title HttpResponseMessage.Statuscode fixed + proxying to IIS Express explained HttpResponseMessage.Statuscode fixed Mar 8, 2022
@KlausVcb
Copy link
Contributor Author

KlausVcb commented Mar 8, 2022

new PR #297 created, let me know if I did it wrong, 100% devops until recently so still getting used to Github

@josesimoes josesimoes changed the title HttpResponseMessage.Statuscode fixed Fix HttpResponseMessage.Statuscode not returning backing field Mar 8, 2022
@josesimoes
Copy link
Member

new PR #297 created, let me know if I did it wrong, 100% devops until recently so still getting used to Github

All great!
The only thing missing was to remove the readme change from this PR.
I'll do that by merging the changes in this PR once that one is merged.

@josesimoes josesimoes enabled auto-merge (squash) March 8, 2022 09:09
@josesimoes josesimoes merged commit 516c96a into nanoframework:develop Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants