Skip to content

Fix primitive datatypes #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

Fix primitive datatypes #104

merged 1 commit into from
May 29, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Remove System.WeakReference from primitive data types.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Fix primitive datatypes
201fabc 
- Remove System.WeakReference from primitive data types.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added the Type: bug Something isn't working label May 29, 2020
@nfbot
Copy link
Member

nfbot commented May 29, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit ffff359 into develop May 29, 2020
@josesimoes josesimoes deleted the fix-primitive-datatypes branch May 29, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WeakReference causes stack corruption when null
2 participants
@josesimoes @nfbot