-
Notifications
You must be signed in to change notification settings - Fork 12
Split graphics in 2 libraries a core and a full one #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should bitmap be in the core? |
I cannot because it is deeply linked to the native part. Creating an abrasct or equivalent has not that much sense neither. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOW!! This was massive!
A TON of work reworkin, organizing and adding comments (almost!) everywhere.
Impressive work (I'm sure several parts where rather tedious). Thanks for taking care of this.
Just a couple of minor things I've bumped into.
For a future discussion: a general clean-up is due for things like mouse events and keys, keyboard with function keys, numeric keypad, sessions, etc. All this is bagagge from the NETMF days intended for usage scenarious that we are not (nor planning) to address.
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now! Thanks.
Description
Motivation and Context
Second step will be to adjust the Sample repo.
Third step will be to adjust all the IoT Device nugets to include this class. The "old" System.Drawing containing only the Color today will be able to get retired.
How Has This Been Tested?
This has been tested on a real device with the primitive sample. An ESP32 Wrover.
Screenshots
Types of changes
Checklist: