Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix option errors in xreq, and improve test coverage. #133

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 28, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #133 into master will increase coverage by 2%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #133    +/-   ##
========================================
+ Coverage   62.01%   64.02%    +2%     
========================================
  Files          48       48            
  Lines        5550     5587    +37     
========================================
+ Hits         3442     3577   +135     
+ Misses       1851     1749   -102     
- Partials      257      261     +4
Impacted Files Coverage Δ
protocol/xreq/xreq.go 91.93% <100%> (+47.97%) ⬆️
internal/test/options.go 100% <100%> (ø) ⬆️
transport/conn.go 71.42% <0%> (-1.59%) ⬇️
internal/test/closed.go 100% <0%> (ø) ⬆️
protocol/xrep/xrep.go 53.04% <0%> (+5.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b305491...aa25851. Read the comment docs.

@gdamore gdamore merged commit aa25851 into master Nov 28, 2019
@gdamore gdamore deleted the xreqtest branch November 28, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants