Skip to content

change blob example to be self contained #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2023
Merged

change blob example to be self contained #101

merged 1 commit into from
Feb 2, 2023

Conversation

orena1
Copy link
Contributor

@orena1 orena1 commented Jan 31, 2023 •
edited
Loading

Description

Currently for running the blob example, one need to import 2 other modules, they were indeed imported in the previous code, but I think it is better to have this example self-contained as this is a tutorial. Also, because the screenshot does not correspond to the output of running both examples one after the other. Thanks

Type of change

  • Fixes or improves existing content
  • Fixes or improves workflow, documentation build or deployment

Final checklist:

  • My PR is the minimum possible work for the desired functionality

@orena1
change blob example to be self contained
4c4d7e6 
Currently  for running the blob example, one need to import 2 other modules, they were indeed important in the previous code, but I think it is better to have this example self-contained as this is a tutorial. Also, because the screenshot does not correspond to the output of running both examples one after the other.
Thanks
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 31, 2023
Czaki
Czaki approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@Czaki Czaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

psobolewskiPhD
psobolewskiPhD approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! Definitely want the code blocks to be copy-paste-able.

@psobolewskiPhD psobolewskiPhD merged commit c3d08e3 into napari:main Feb 2, 2023
@psobolewskiPhD psobolewskiPhD added this to the 0.4.18 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Czaki Czaki Czaki approved these changes

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

Assignees

@orena1 orena1

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.4.18
Development

Successfully merging this pull request may close these issues.
3 participants
@orena1 @Czaki @psobolewskiPhD