Skip to content

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Feb 17, 2023

Description

Close #107
Switches to use the default GITHUB_TOKEN rather than making adding a new CIRCLECI_TOKEN
This makes the workflow match the README of the action:
larsoner/circleci-artifacts-redirector-action
This is also used commonly in other repos, see for example numpy/numpy:
numpy/numpy@1426570/.github/workflows/circleci.yml#L18

Type of change

  • Fixes or improves existing content

References

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@melissawm
Copy link
Member

I don't believe this will change anything since the token needs to be created first.

@Czaki
Copy link
Contributor Author

Czaki commented Feb 17, 2023

I don't believe this will change anything since the token needs to be created first.

it will change nothing as the action is executed using the workflow version from the main branch, not from PR.

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Czaki As I posted in the issue, changing the token name should work—all the repo settings seem fine.
I think you can revert the other changes and update the description, maybe something like:

Close #107
Switches to use the default GITHUB_TOKEN rather than making adding a new CIRCLECI_TOKEN
This makes the workflow match the README of the action:
https://github.com/larsoner/circleci-artifacts-redirector-action
This is also used commonly in other repos, see for example numpy/numpy:
https://github.com/numpy/numpy/blob/14265704f6fb3b77ca2739329d35ff49293d26df/.github/workflows/circleci.yml#L18

Then we need to merge to see any effect.

@Czaki Czaki force-pushed the bugfix/repo_token branch from ef024c6 to 9b77c12 Compare February 18, 2023 19:50
@Czaki Czaki marked this pull request as ready for review February 18, 2023 19:50
@Czaki
Copy link
Contributor Author

Czaki commented Feb 18, 2023

As you can see, the change of token leads to a properly working workflow.

Czaki#1

Also I notice some problem in build process napari/napari#5572

@Czaki Czaki changed the title Test if change secret in circleci action works Change CIRCLECI_TOKEN to GITHUB_TOKEN in circleci.yml workflow file. Feb 18, 2023
@Czaki Czaki changed the title Change CIRCLECI_TOKEN to GITHUB_TOKEN in circleci.yml workflow file. Change CIRCLECI_TOKEN to GITHUB_TOKEN in circleci.yml workflow file. Feb 18, 2023
@Czaki Czaki merged commit d3b49f9 into napari:main Feb 18, 2023
@Czaki Czaki deleted the bugfix/repo_token branch February 18, 2023 20:07
@Czaki
Copy link
Contributor Author

Czaki commented Feb 18, 2023

It also works here. You can see in #110.

@melissawm
Copy link
Member

Thanks, @Czaki !

@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of link to documentation preview
3 participants