Skip to content

Fix closing of html comment in PR template #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

Fix closing of html comment in PR template #168

merged 1 commit into from
May 31, 2023

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented May 30, 2023

Description

The PR template contains non closed HTML comment. This PR fix it.

Type of change

  • Fixes or improves existing content
  • Adds new content page(s)
  • Fixes or improves workflow, documentation build or deployment

References

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@github-actions github-actions bot added the task label May 30, 2023
melissawm
melissawm approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😄

@jni jni merged commit e5e2d39 into napari:main May 31, 2023
@Czaki Czaki deleted the fix_pr_template branch May 31, 2023 05:16
@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissawm melissawm melissawm approved these changes

Assignees

@Czaki Czaki

Labels
task
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Czaki @melissawm @jni @psobolewskiPhD