Run PR depenecy check on every comment added to PR #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Though maybe every comment is still a lot, since it will spin up a VM every time? shall we have a trigger word instead? |
|
We may, like in napari/napari#6101. What phase did you suggest? |
|
Yeah better. Something like "dependency closed"? |
|
Maybe just "dependency"? |
|
Though it will fire if we talk about library dependencies xD |
|
hm. Maybe? I do not know. but it is now easy to suggest proper phase by "request changes" |
|
would |
|
deps can also be issues in principle I think... I think we're being overzealous here, let's just merge and if problems arise we can solve them :P |
|
@Czaki please update description first! |
|
@brisvag updated description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the current state, the core dev needs to restart the dependency check, or a dummy commit needs to be done.
As the PR dependency check is cheap, I think it is worth triggering it on every comment, so if a user write comment containing
mergethe check will be restartedType of change
References
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_comment-use-issue_comment