Add env constraint to 'deploy_docs' workflow #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
approved these changes
Dec 4, 2023
psobolewskiPhD
approved these changes
Dec 4, 2023
|
Agreed, would be great for this to go in! |
|
Merged, lets see what happens on deployment! |
melissawm
pushed a commit
that referenced
this pull request
Dec 5, 2023
# References and relevant issues Fix failing deployment: https://github.com/napari/docs/actions/runs/7093394130/job/19306680514 caused by #287 # Description In the deploy workflow, napari is cloned into napari-repo: `path: napari-repo # place in a named directory` fixing that here so that the constraints path in the ENV variable is also using napari-repo and not napari. Obviously overlooked this difference when reviewing #287 Yet another reason to use just one workflow, #284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Possible f i x es #283
Description
Add constraints as env variable to the build step of 'deploy_docs' workflow, matching the 'build_docs' workflow.
(no further improvement of these workflows attempted in this PR, they can be done later, see #284)