[Maint] fix build_and_deploy.yml paths #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobolewskiPhD
added
maintenance
|
The rendered docs in the CI look off for me ? |
DragaDoncila
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
closes: #383
The deploy workflow "works" but is deploying nothing:
https://github.com/napari/docs/actions/runs/8563891050/job/23469798992#step:4:1833
The artifact is extracted to:
https://github.com/napari/docs/actions/runs/8563891050/job/23469798992#step:2:12
There is confusing paths with docs and docs. It looks like the deployment is relative to the last working dir and not the top-level.
Description
In this PR I set the path of the download action to
html(instead of downloading by name, which shouldn't matter here) which should make things clearer and then use that for the deployment.