feat(argon2): support salt input on Argon2 #660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I tried to implement supporting a pre-defined salt for the argon2 hashing.
I'm not familiar with Rust so I struggle to manage the conversion from the Js Buffer and the Rust SaltString, there are some unrecognized chars in the buffer.
I'm not sure why but this package isn't using the types defined in the documentation so I tried a few things without success.
Let me know if it's doable, that will be really helpful for us to have the salt supported 👍