Gavin edits1 #129
Merged
Gavin edits1 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menoua
approved these changes
Apr 3, 2023
gavinmischler
added a commit
that referenced
this pull request
Apr 3, 2023
* Align stimulus function (first) First working version of the align_stimulus_to_recording function in the naplib.naplab module * Simplify and document Simplified alignment by removing arguments initially added to improve efficiency (not needed with cross-correlation method), and improved doc string * Test and docs Added test data, test function, and file to generate docs * Repair test_segment_functions Whoops * Actually fixed * *sigh* * Verbose fixes Adding docstring for verbose and only doing any prints if verbose=True * process ieeg (#122) * load_tdt and load_nwb (#119) * load_tdt and load_nwb * docs for load functions * requirements for pynwb * import error * load_wav_dir * loaders and rereference * tests * Update process_ieeg.py * Update __init__.py * Update process_ieeg.py * Update process_ieeg.py * Update __init__.py * Fixed Typing in _infer_freq_bands() * Update process_ieeg.py * Update process_ieeg.py * Replacing inds with times * pkl_file to data_path * Fixing time issue * Load EDF functionality * Update __init__.py * Update io.rst * Fixing times and inds * Adding graceful failure to alignment * float32 * filter hilbert and process ieeg updates * fix bug * edits to process_ieeg and alignment stereo allowed * edits to process ieeg * debug * references/index.rst * Multi-level verbosity * Memory usage optimization * Bug fix * Memory usage optimization * Fix bug in `filter_butter` * Add test for in-place filters * Suppress `ConstantInputWarning` during alignment * More compact alignment logs * Minor change to parallelization in filter_hilbert * Fix tests to correspond to new filter_hilbert API * Bug fix * Revert commit `9a79f89` * Change `n_jobs` default values to 1 * Separated `filter_hilbert` and `filterbank_hilbert` * Update changelog.rst * Gavin edits1 (#129) * add fs_out in process_ieeg and change default rereference_method to 'avg' * fix bug with cmr amp list vs array * fix import plt in alignment.py * remove gavin debug line * Update test_naplab_functions.py * fix test issue (#131) * docstring in log_level * Fixed alignment docstring * fixes (#132) * fixes * docstring filter_hilbert * docstring filter --------- Co-authored-by: Vinay Raghavan <42253618+vinaysraghavan@users.noreply.github.com> Co-authored-by: Menoua Keshishian <39179450+menoua@users.noreply.github.com> Co-authored-by: Menoua Keshishian <mk4011@columbia.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Fixes issue where common referencing broke process_ieeg.
Changes default rereference_method to be 'avg' rather than None. This will still only be used if rereference_grid is passed in, which is default None
Any other comments?