-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hackathon #130
Merged
Merged
Hackathon #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First working version of the align_stimulus_to_recording function in the naplib.naplab module
Simplified alignment by removing arguments initially added to improve efficiency (not needed with cross-correlation method), and improved doc string
Added test data, test function, and file to generate docs
Adding docstring for verbose and only doing any prints if verbose=True
* load_tdt and load_nwb * docs for load functions * requirements for pynwb * import error * load_wav_dir * loaders and rereference * tests
Load EDF file format
Major memory usage optimization in iEEG pipeline
* add fs_out in process_ieeg and change default rereference_method to 'avg' * fix bug with cmr amp list vs array * fix import plt in alignment.py * remove gavin debug line
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 75.04% 65.29% -9.75%
==========================================
Files 41 49 +8
Lines 2304 2991 +687
==========================================
+ Hits 1729 1953 +224
- Misses 575 1038 +463
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
menoua
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Full preprocessing pipeline for iEEG and many small changes. Bumping to v0.2.0 with this PR.
Any other comments?