Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon #130

Merged
merged 63 commits into from
Apr 3, 2023
Merged

Hackathon #130

merged 63 commits into from
Apr 3, 2023

Conversation

gavinmischler
Copy link
Collaborator

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Full preprocessing pipeline for iEEG and many small changes. Bumping to v0.2.0 with this PR.

Any other comments?

vinaysraghavan and others added 30 commits March 31, 2023 14:35
First working version of the align_stimulus_to_recording function in the naplib.naplab module
Simplified alignment by removing arguments initially added to improve efficiency (not needed with cross-correlation method), and improved doc string
Added test data, test function, and file to generate docs
Adding docstring for verbose and only doing any prints if verbose=True
* load_tdt and load_nwb

* docs for load functions

* requirements for pynwb

* import error

* load_wav_dir

* loaders and rereference

* tests
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #130 (bd2a864) into main (eb9fb48) will decrease coverage by 9.75%.
The diff coverage is 36.51%.

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   75.04%   65.29%   -9.75%     
==========================================
  Files          41       49       +8     
  Lines        2304     2991     +687     
==========================================
+ Hits         1729     1953     +224     
- Misses        575     1038     +463     
Impacted Files Coverage Δ
naplib/data.py 83.33% <0.00%> (ø)
naplib/naplab/process_ieeg.py 7.47% <7.47%> (ø)
naplib/naplab/alignment.py 9.23% <9.23%> (ø)
naplib/io/load_tdt.py 14.28% <14.28%> (ø)
naplib/io/load_nwb.py 33.33% <33.33%> (ø)
naplib/io/load_wav_dir.py 42.85% <42.85%> (ø)
naplib/preprocessing/rereference.py 55.17% <55.17%> (ø)
naplib/preprocessing/filter_hilbert.py 89.77% <88.18%> (+2.53%) ⬆️
naplib/io/load_edf.py 96.49% <96.49%> (ø)
naplib/__init__.py 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@menoua menoua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants