Prevent error from trying to remote view as god. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the reference: <https://forums.factorio.com/viewtopic.php?p=131915#p131915>, it is perfectly feasible for the player character to be nil. The right thing happens anyway, but let's avoid raising an error now that we're expecting it. It would be nice if we could support that properly, but that's an entirely different enhancement.
|
Actually, as per #30, the error is correct in as much as we're really not handling the god controller and we should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the reference: https://forums.factorio.com/viewtopic.php?p=131915#p131915, it is perfectly feasible for the player character to be nil.
The right thing happens anyway, but let's avoid raising an error now that we're expecting it. It would be nice if we could support that properly, but that's an entirely different enhancement.