Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esm compatibility #17

Merged
merged 4 commits into from
Mar 21, 2023
Merged

Conversation

drzraf
Copy link
Contributor

@drzraf drzraf commented Feb 24, 2023

  • Standardized the imports
  • Remove unused dependencies
  • Remove the dependency on https://react-select.com/home which is definitely not worth it. <SelectControl> works as well
  • Added a webpack.config.js sample
  • Rebuilt using NODE_ENV=production
    • Reduced story-timeline-child/index.js by 5%
    • Reduced story-timeline/index.js by 77%

@aniketcoolplugins007 aniketcoolplugins007 merged commit ac5a503 into narinder9:main Mar 21, 2023
@drzraf
Copy link
Contributor Author

drzraf commented Mar 21, 2023

Should we make PR against main or dev?

@aniketcoolplugins007
Copy link
Collaborator

aniketcoolplugins007 commented Mar 22, 2023 via email

@drzraf
Copy link
Contributor Author

drzraf commented Apr 4, 2023

Dears,

This didn't get in... I still see the import miss their .js inside the latest version of main.
Why was it "reverted" without reason?

@drzraf
Copy link
Contributor Author

drzraf commented Apr 4, 2023

Please fix it by running this inside includes/cool-timeline-block:

sed -ri "/^import.*from [\"']\./{/\.(js|scss|png)/!s!([\"']);?\$!.js\1;!}" $(git g -lPw ^import -- src/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants