Skip to content

Conversation

Donnie-Ice
Copy link
Collaborator

@Donnie-Ice Donnie-Ice commented Sep 23, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

@Donnie-Ice Donnie-Ice requested a review from dccutrig September 23, 2025 21:03
@Donnie-Ice Donnie-Ice self-assigned this Sep 23, 2025
@Donnie-Ice Donnie-Ice linked an issue Sep 23, 2025 that may be closed by this pull request
@Donnie-Ice
Copy link
Collaborator Author

Does not pass kmc_build CI due to function signature changes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 84.58611% with 162 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.72%. Comparing base (478c31f) to head (69519f2).
⚠️ Report is 136 commits behind head on dev.

Files with missing lines Patch % Lines
src/core/crypto_aos.c 60.00% 15 Missing and 15 partials ⚠️
src/core/crypto_config.c 77.77% 21 Missing and 7 partials ⚠️
src/core/crypto_tc.c 48.00% 3 Missing and 23 partials ⚠️
src/core/crypto.c 61.53% 10 Missing and 15 partials ⚠️
src/core/crypto_tm.c 52.00% 14 Missing and 10 partials ⚠️
test/unit/ut_sadb_err_cases_kmc_crypto.c 0.00% 16 Missing ⚠️
test/unit/ut_mysql_m_tls_connection.c 0.00% 4 Missing ⚠️
test/unit/ut_mysql_tls_connection.c 0.00% 4 Missing ⚠️
src/core/crypto_print.c 94.59% 2 Missing ⚠️
src/core/crypto_key_mgmt.c 0.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #493      +/-   ##
==========================================
- Coverage   82.00%   81.72%   -0.28%     
==========================================
  Files          39       39              
  Lines       11945    12925     +980     
  Branches      973     1122     +149     
==========================================
+ Hits         9795    10563     +768     
- Misses       1778     1933     +155     
- Partials      372      429      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Update Crypto Config and Managed Parameters (MAJOR CHANGES)
2 participants