Refactor "Compiled-out" code (ifdef)

[jphickey]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
HS contains a significant amount of code that can be compiled-out via #if HS_MAX_EXEC_CNT_SLOTS != 0

To comply with coding standards this should be refactored so it does not need to be compiled out.

To Reproduce
N/A

Expected behavior
Should not remove entire functions via #if as this can negatively affect unit testing. Switches like this increases the testing permutations required - technically should test it both ways, but we are not currently doing so.

System observed on:
N/A

Additional context
In this case the default value of HS_MAX_EXEC_CNT_SLOTS is 32, so this is compiled-in by default, but we never actually test the compiled-out option to see if it works correctly.

Requirement for this feature should be revisited first (i.e. is there a reason why we really need to have the option to set HS_MAX_EXEC_CNT_SLOTS to 0, as other configurable parameters do not have such an option).

If it is required to compile this out entirely, then a source-selection would be preferable over chunks of #if code.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.