Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cppcheck unread variable errors in hs_monitor.c #73

Closed
2 tasks done
jphickey opened this issue Feb 22, 2023 · 0 comments · Fixed by #72
Closed
2 tasks done

Cppcheck unread variable errors in hs_monitor.c #73

jphickey opened this issue Feb 22, 2023 · 0 comments · Fixed by #72
Labels
bug Equuleus-rc1
Milestone
Equuleus

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Cppcheck is currently reporting the following style issues:

severity location error id issue
style fsw/src/hs_monitors.c:641 unreadVariable Variable 'EntryResult' is assigned a value that is never used.
style fsw/src/hs_monitors.c:643 unreadVariable Variable 'ResourceType' is assigned a value that is never used.
style fsw/src/hs_monitors.c:644 unreadVariable Variable 'NullTerm' is assigned a value that is never used.

To Reproduce
Run Cppcheck workflow

Expected behavior
Should run clean

System observed on:
Github hosted runner

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey changed the title Cppcheck unused variable errors in hs_monitor.c Cppcheck unread variable errors in hs_monitor.c Feb 22, 2023
@jphickey jphickey added the bug label Feb 22, 2023
jphickey added a commit to jphickey/HS that referenced this issue Feb 22, 2023
@jphickey
Fix nasa#73, unread variables
5921b1d 
Do not assign a value to variables where a value is assigned later and
the first value is never read.
jphickey added a commit to jphickey/HS that referenced this issue Feb 22, 2023
@jphickey
Fix nasa#73, unread variables
c29d4f6 
Do not assign a value to variables where a value is assigned later and
the first value is never read.
@jphickey jphickey mentioned this issue Feb 22, 2023
Closed
2 tasks
jphickey added a commit to jphickey/HS that referenced this issue Feb 22, 2023
@jphickey
Fix nasa#73, unread variables
56a9a4e 
Do not assign a value to variables where a value is assigned later and
the first value is never read.
@jphickey jphickey mentioned this issue Feb 22, 2023
Merged
2 tasks
jphickey added a commit to jphickey/HS that referenced this issue Feb 23, 2023
@jphickey
Fix nasa#73, unread variables
67477f6 
Do not assign a value to variables where a value is assigned later and
the first value is never read.
dzbaker added a commit that referenced this issue Feb 23, 2023
@dzbaker
Merge pull request #72 from jphickey/fix-69-compileout-code
8fcb6ec 
Fix #69, Fix #73, remove conditional compiles from code
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Equuleus-rc1
Projects
None yet
Milestone
Equuleus
2 participants
@jphickey @dmknutsen