Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #97, Support custom override of lc_msgids #98

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 13, 2023

Checklist (Please check before submitting)

Describe the contribution

Testing performed
CI

Expected behavior changes
Supports override of msgids from a single file

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@dzbaker
Copy link
Contributor

dzbaker commented Sep 14, 2023

CCB 14 September 2023: @jphickey will discuss with @skliper.

@skliper
Copy link
Contributor Author

skliper commented Oct 31, 2023

@jphickey @dzbaker - could I get information on the concern w/ this PR or an ETA for expecting a response?

@chillfig
Copy link
Contributor

chillfig commented Nov 9, 2023

CCB: 11-9-2023: put on hold. Requires further consideration

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally took a closer look at this, and yeah, its good - basically the same as what we have been adding to other apps for the similar purpose.

@dzbaker dzbaker merged commit 9a2e639 into nasa:main Nov 30, 2023
17 checks passed
@skliper skliper deleted the fix97-msgid_custom_override branch April 1, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support overriding msgids from a single project file
4 participants