Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage tests for PSP modules #435

Closed
jphickey opened this issue Aug 6, 2024 · 2 comments · Fixed by #436
Closed

Add coverage tests for PSP modules #435

jphickey opened this issue Aug 6, 2024 · 2 comments · Fixed by #436
Labels
coverage enhancement New feature or request

Comments

@jphickey
Copy link
Contributor

jphickey commented Aug 6, 2024

Is your feature request related to a problem? Please describe.
The coverage testing on PSP modules is not complete. There is only a coverage test for 2 of the modules, but not the rest.

Describe the solution you'd like
Add coverage testing functions for all PSP modules

Describe alternatives you've considered
N/A

Additional context
Customer/Stakeholder requirement

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey added the enhancement New feature or request label Aug 6, 2024
@skliper
Copy link
Contributor

skliper commented Aug 6, 2024

I don't see coverage analysis in CI for PSP. Could that be added to show what's covered or not for the entire submodule? Looks like there's an issue from 2015 :) #18

This was referenced Aug 7, 2024
Closed
Closed
Merged
Merged
jphickey added a commit to jphickey/PSP that referenced this issue Aug 12, 2024
@jphickey
Fix nasa#435, add coverage tests for PSP modules
f9675a5 
Adds a coverage test implementation for all existing PSP modules.  This
should get 100% coverage on all lines and branches.
@jphickey jphickey mentioned this issue Aug 12, 2024
Merged
2 tasks
@jphickey
Copy link
Contributor Author

I don't see coverage analysis in CI for PSP. Could that be added to show what's covered or not for the entire submodule? Looks like there's an issue from 2015 :) #18

I believe we only run the coverage tests as part of the CI for the entire bundle. In theory we could make a script that just builds the PSP coverage tests and does so under the PSP CI. We should also make the results more visible. However that will have to be done as a follow-on as the stakeholders want the coverage tests ASAP.

jphickey added a commit to jphickey/PSP that referenced this issue Aug 12, 2024
@jphickey
Fix nasa#435, add coverage tests for PSP modules
fc41d65 
Adds a coverage test implementation for all existing PSP modules.  This
should get 100% coverage on all lines and branches.
jphickey added a commit to jphickey/PSP that referenced this issue Aug 12, 2024
@jphickey
Fix nasa#435, add coverage tests for PSP modules
43df4a1 
Adds a coverage test implementation for all existing PSP modules.  This
should get 100% coverage on all lines and branches.
chillfig pushed a commit to jphickey/PSP that referenced this issue Aug 12, 2024
Fix nasa#435, Adds eeprom_direct lcov
6c99a9d
jphickey added a commit to jphickey/PSP that referenced this issue Aug 14, 2024
@jphickey
Fix nasa#435, convert internal PSP UT stubs into handler pattern
257eafa
jphickey added a commit to jphickey/PSP that referenced this issue Aug 15, 2024
@jphickey
Fix nasa#435, change eeprom direct internal var to cpuaddr
8fe4379
jphickey added a commit to jphickey/PSP that referenced this issue Aug 15, 2024
@jphickey
Fix nasa#435, convert internal PSP UT stubs into handler pattern
c7f6359 
Implements handlers to mimic old stub behavior whenever possible
dzbaker added a commit that referenced this issue Aug 16, 2024
@dzbaker
Merge pull request #436 from jphickey:fix-435-pspmod-covtests
bf95d9b 
Fix #435, add coverage tests for PSP modules
@dzbaker dzbaker mentioned this issue Aug 16, 2024
Merged
2 tasks
jphickey added a commit to jphickey/PSP that referenced this issue Sep 12, 2024
@jphickey
Fix nasa#435, correct init in PCS_malloc call
2336dde 
The handler executes after the stub count increments, thus this
needs to check for 1 to indicate the first call, not 0.
dzbaker added a commit that referenced this issue Sep 16, 2024
@dzbaker
Merge pull request #436 from jphickey:fix-435-pspmod-covtests
61b1230 
Fix #435, add coverage tests for PSP modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coverage enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #435, add coverage tests for PSP modules jphickey/PSP
3 participants
@jphickey @skliper @chillfig