Fix #305, do not override add_psp_module for coverage test #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
Implements a differently-named function instead, which does mostly the same thing, but does not directly re-add the original subdirectory. This does repeat some info (e.g. the list of FSW source files) that was not repeated otherwise, but it works in general.
jphickey
force-pushed
the
fix-305-pspmod-covtest
branch
from
b4d648c
to
3d2624b
Compare
|
@excaliburtb @tngo67 - could you review and let me know if this would this impact your distribution? |
|
This doesn't appear to be a problem for us. |
skliper
approved these changes
Sep 7, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 7, 2021
2 tasks
astrogeco
added
CCB:Approved
|
CCB:2021-09-08 APPROVED
|
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Sep 10, 2021
**Combines** nasa/cFE#1939, v6.8.0-rc1+dev994 nasa/osal#1145, v5.1.0-rc1+dev604 nasa/PSP#307, v1.5.0-rc1+dev124 nasa/sch_lab#87, v2.4.0-rc1+dev47 **Includes** *cFE* nasa/cFE#1903, Update directory diagrams in application developer guide nasa/cFE#1922, SB code coverage improvements #1905, Improve SB coverage nasa/cFE#1936, Improve ES code coverage nasa/cFE#1938, Enforce minimum code coverage nasa/cFE#1940, Update dev guide for MSG and SBR nasa/cFE#1941, Support unimplemented features in MSG FT *osal* nasa/osal#1144, Regex update in coverage enforcement to match .0 nasa/osal#1142, Add typecast to memchr call *psp* nasa/PSP#307, check that module type is not invalid nasa/PSP#306, do not override add_psp_module for coverage test *sch_lab* nasa/sch_lab#86, add CmdCode to sch_lab_table nasa/sch_lab#88, Fix missing typedef Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Implements a differently-named function instead, which does mostly the same thing as the override had done, but does not directly re-add the original subdirectory. This does repeat some info (e.g. the list of FSW source files) that was not repeated otherwise, but it works in general.
Fixes #305
Testing performed
Build and sanity check CFE in a configuration that uses several PSP modules for Hardware access
Expected behavior changes
CMake builds the FSW modules correctly
System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.