Added sparse mapping launch script #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoltin
approved these changes
Dec 23, 2021
|
I pulled this in, I tested that it works, except for the last line, node pkg="rosservice" type="rosservice" name="enable_sparse_mapping" args="call --wait /loc/ml/enable true" failing. I wrote an email about that. |
oleg-alexandrov
added a commit
that referenced
this pull request
Dec 23, 2021
This reverts commit 4af88c0.
|
I think I am very bad at dealing with pull requests. I merged this in prematurely, the clicked on "revert" to see what it will do, which just created a branch, which I plan to wipe. I think there's not much harm I pulled this in too early. I will keep an eye on the unresolved issue above which shows up only on ROS melodic and not with ROS kinetic. |
|
It's fine, just make a new pull request when you fix that problem. |
|
I will look at this this week. |
luisa-mao
pushed a commit
to luisa-mao/astrobee-1
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the sparse mapping matcher (localization_node) live using an input bagfile and optionally saves the results to a bagfile. Created for @oleg-alexandrov for use with the ISAAC pipeline.