-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1480, Expand FS Header Functional tests. #1638
Merged
astrogeco
merged 2 commits into
nasa:integration-candidate
from
zanzaben:fix1489_expend_FS_Header_functional_tests
Jun 30, 2021
Merged
Fix #1480, Expand FS Header Functional tests. #1638
astrogeco
merged 2 commits into
nasa:integration-candidate
from
zanzaben:fix1489_expend_FS_Header_functional_tests
Jun 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
approved these changes
Jun 24, 2021
astrogeco
added
the
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
label
Jun 24, 2021
skliper
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider renaming internal macros to make it clear these are not supplied by utassert. Local naming would also avoid potential future conflicts...
zanzaben
force-pushed
the
fix1489_expend_FS_Header_functional_tests
branch
from
June 28, 2021 17:27
1146ccb
to
1c0fa95
Compare
zanzaben
force-pushed
the
fix1489_expend_FS_Header_functional_tests
branch
from
June 28, 2021 18:58
1c0fa95
to
30d1b54
Compare
skliper
approved these changes
Jun 28, 2021
astrogeco
added
CCB:Approved
Indicates code review and approval by community CCB
and removed
CCB:Ready
Ready for discussion at the Configuration Control Board (CCB)
labels
Jun 30, 2021
CCB:2021-06-30 APPROVED |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 30, 2021
**Combines** nasa/cFE#1654 **Includes** nasa/cFE#1444, Change index type to resolve infinite loop warning nasa/cFE#1653, Adding coverage for cfe_es_task.c nasa/cFE#1638, Expand FS Header Functional tests.
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 7, 2021
**Combines** nasa/cFE#1654, cfe v6.8.0-rc1+dev739 nasa/osal#1098, osal v5.1.0-rc1+dev564 **Includes** nasa/cFE#1444, Change index type to resolve infinite loop warning nasa/cFE#1653, Adding coverage for cfe_es_task.c nasa/cFE#1638, Expand FS Header Functional tests. nasa/cFE#1637, Complete coverage for cfe_es_start.c and cfe_es_syslog.c nasa/osal#1081, add range to OS_TaskDelay checks nasa/osal#1085, return OS_OBJECT_ID_UNDEFINED for root task ID on RTEMS nasa/osal#1090, increase UT symbol dump size limit nasa/osal#1091, do not register RTOS timer for external sync nasa/osal#1093, avoid task delete during UtPrintf nasa/osal#1097, Add osal prefix to Network API group nasa/osal#1092, increase timeout in network-api-test Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com> Co-authored-by: Himanshu <himanshu007-creator@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #1480
Expands FS Header functional tests to include error checking.
Testing performed
Build and run unit test
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC