Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions to run on Node 16 instead of Node 12 - Bump to @v3 #1804

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) N/A
Has Unit Tests (y/n) n
Builds Without Errors (y/n) See CI outputs
Unit Tests Pass (y/n) n
Documentation Included (y/n) n

Change Description

This PR updates the NodeJS version of GitHub Actions to node16, instead of node12.

Rationale

Node 12 is no longer supported as of 30 Apr 2022, as a result, GitHub has begun the process of deprecating Node 12 for GitHub Actions.

Several of their actions have already migrated, like checkout, upload/download-artifacts.

GitHub asks Actions maintainers to update their actions to work on Node 16 instead of Node 12.

Testing/Review Recommendations

See if the CI is still on.

Future Work

None

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. We've been running @v3 for the most recently introduced workflows without any issues (CodeQL, etc..), so I don't have any concern with this.

@LeStarch
Copy link
Collaborator

LeStarch commented Dec 8, 2022

Mac CI failure previously fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants