Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't enter Edit mode twice #25

Closed
VWoeltjen opened this issue Jun 25, 2015 · 1 comment
Closed

Can't enter Edit mode twice #25

VWoeltjen opened this issue Jun 25, 2015 · 1 comment

Comments

@VWoeltjen
Copy link
Contributor

Navigate to a domain object, click Edit to enter Edit mode, then click Cancel to leave Edit mode.
Click Edit again and observe that the URL changes, but the client remains in Browse mode.
Desired behavior is that the subsequent click goes into Edit mode.

This appears to be fixed if one checks the new path before cancelling the route change, e.g.

                    if ($location.path().indexOf("/browse/") === 0) {
                        $route.current = priorRoute;
                    }

... in the $locationChangeSuccess listeners in BrowseController and BrowseObjectController
shivamndave pushed a commit to shivamndave/openmctweb that referenced this issue Jun 26, 2015
[Addressability] Re-Edit Bug
3de4473 
Fixed re-edit but by implementing
what Victor said in issue nasa#25. Adding
check on /browse/ part of url and then
changing route works WTD 23.
@shivamndave shivamndave mentioned this issue Jun 26, 2015
Merged
VWoeltjen added a commit that referenced this issue Jun 27, 2015
@VWoeltjen
Merge pull request #27 from shivamndave/open25
12b34b5 
Addresses #25
@VWoeltjen
Copy link
Contributor Author

Verified during testathon 9/17/2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VWoeltjen