Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Representation] Pre-fetch templates #388

Merged
merged 5 commits into from
Dec 8, 2015
Merged

[Representation] Pre-fetch templates #388

merged 5 commits into from
Dec 8, 2015

Conversation

VWoeltjen
Copy link
Contributor

Pre-fetch templates to address #383, and situations where #58 is not well-messaged due to failure to load templates.

Pre-fetching is done using the runs extension category (map's to angular.Module.runs), with highest priority. This occurs before routes are handled, so the relevant HTTP requests are issued before search indexing etc. commences.

Notably, there is no dependency between these requests resolving and application startup, so it is possible in principle for a dialog to have not loaded before the user is able to take actions that might fail. Think the set of conditions required for this to happen is obscure enough that we will not see this in practice; prefer to address this later with a precompilation step

Verified by:

  • Serve Open MCT Web with node app.js -i platform/persistence/elastic -x platform/persistence/local
  • Start ElasticSearch
  • Open application in Chrome, browse to an object
  • Kill node and ElasticSearch
  • Return to Chrome, use the Remove action on an object
  • Observe a blocking dialog notifying me of an error when saving

Author Checklist

  1. Changes address original issue? Y
  2. Unit tests included and/or updated with changes? Y
  3. Command line build passes? Y
  4. Changes have been smoke-tested? Y

@VWoeltjen VWoeltjen added this to the Baxter milestone Dec 8, 2015
@larkin larkin merged commit 6cef663 into master Dec 8, 2015
@larkin
Copy link
Contributor

larkin commented Dec 8, 2015

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? Y
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants