[Representation] Pre-fetch templates #388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-fetch templates to address #383, and situations where #58 is not well-messaged due to failure to load templates.
Pre-fetching is done using the
runs
extension category (map's toangular.Module.runs
), with highest priority. This occurs before routes are handled, so the relevant HTTP requests are issued before search indexing etc. commences.Notably, there is no dependency between these requests resolving and application startup, so it is possible in principle for a dialog to have not loaded before the user is able to take actions that might fail. Think the set of conditions required for this to happen is obscure enough that we will not see this in practice; prefer to address this later with a precompilation step
Verified by:
node app.js -i platform/persistence/elastic -x platform/persistence/local
Author Checklist