-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLA on File] fix: [Safari] Time conductor ticks (#3537) #6033
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6033 +/- ##
==========================================
+ Coverage 54.66% 54.75% +0.08%
==========================================
Files 600 600
Lines 23940 24041 +101
Branches 2115 2103 -12
==========================================
+ Hits 13087 13163 +76
- Misses 10254 10280 +26
+ Partials 599 598 -1
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There seem to be more issues with safari - tick text doesn't appear even generally. |
@papo1011 Would you be able to look at the issues listed here? We do realize there's more than the original issue states, but a partial fix is probably not what we want to commit at this point. |
Thanks @papo1011 I'll take a look and get back to you soon. |
I have updated the issue stating the full problem. |
Hi @shefalijoshi today I looked for the causes of the tick labels not visible on reload, I haven't found a good solution :( |
@papo1011 Thank you for contributing to Open MCT! We will close this PR for now but might reopen it if some fix becomes evident down the road. |
mct_safari_time_conductor.mov
Closes #3537
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist