Export display #6562
Merged
Export display #6562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Playwright Test Results Summary✅ 117 Passing - ❌ 1 Failing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/06/2023 02:55:26am UTC) ❌ Failures📄 framework/baseFixtures.e2e.spec.js • 1 FailureTest Case Results
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt |
0% (0)0 / 8 runsfailed over last 7 days |
12.50% (1)1 / 8 runflaked over last 7 days |
📄 functional/plugins/plot/plotLegendSwatch.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Legend color in sync with plot color Testing
Retry 1 • Initial Attempt |
0% (0)0 / 7 runsfailed over last 7 days |
28.57% (2)2 / 7 runsflaked over last 7 days |
📄 functional/plugins/plot/overlayPlot.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Overlay Plot Clicking on an item in the elements pool brings up the plot preview with data points
Retry 1 • Initial Attempt |
0% (0)0 / 7 runsfailed over last 7 days |
100% (7)7 / 7 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6562 +/- ##
==========================================
- Coverage 54.97% 54.71% -0.26%
==========================================
Files 628 628
Lines 26805 26814 +9
Branches 2422 2422
==========================================
- Hits 14736 14672 -64
- Misses 11409 11476 +67
- Partials 660 666 +6
*This pull request uses carry forward flags. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
davetsay
approved these changes
Apr 6, 2023
| Object.keys(this.idMap).forEach(function (oldId) { | ||
| const newId = this.idMap[oldId]; | ||
| treeString = treeString.split(oldId).join(newId); | ||
| }.bind(this)); |
There was a problem hiding this comment.
We don't need no stinking binders!
davetsay
pushed a commit
that referenced
this pull request
Apr 6, 2023
jvigliotta
added a commit
that referenced
this pull request
Apr 17, 2023
unlikelyzero
pushed a commit
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6561
Describe your changes:
Finding and replacing identifiers as well.
All Submissions:
Author Checklist
Reviewer Checklist