Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update UT_SetDefaultReturnValue comment #722

Closed
CDKnightNASA opened this issue Dec 31, 2020 · 0 comments · Fixed by #725 or #767
Closed

update UT_SetDefaultReturnValue comment #722

CDKnightNASA opened this issue Dec 31, 2020 · 0 comments · Fixed by #725 or #767
Assignees
@zanzaben @CDKnightNASA
Labels
docs enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@CDKnightNASA
Copy link
Contributor

While I agree with the new function name, the comments are duplicated from the (now deprecated) UT_SetForceFail(), I suggest a re-write of the comments for this important function.

osal/ut_assert/inc/utstubs.h

Line 183 in d698a4d

* Enable or disable the forced failure mode for the given stub function

@CDKnightNASA CDKnightNASA self-assigned this Dec 31, 2020
@skliper skliper mentioned this issue Jan 4, 2021
Closed
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 4, 2021
@zanzaben
Fix nasa#722 update UT_SetDefaultReturnValue comments
61e27ad
@zanzaben zanzaben mentioned this issue Jan 4, 2021
Merged
@astrogeco astrogeco added this to the 6.0.0 milestone Jan 12, 2021
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 12, 2021
@zanzaben
Fix nasa#722 update UT_SetDefaultReturnValue comments
29cdd51
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 13, 2021
@zanzaben
Fix nasa#722 update UT_SetDefaultReturnValue comments
0039e3e
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 13, 2021
@zanzaben
Fix nasa#722, update UT_SetDefaultReturnValue comments
35a1323
zanzaben added a commit to zanzaben/osal that referenced this issue Jan 22, 2021
@zanzaben
Fix nasa#722, update UT_SetDefaultReturnValue comments
e248041
@astrogeco astrogeco added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Jan 22, 2021
astrogeco added a commit that referenced this issue Jan 22, 2021
@astrogeco
Merge pull request #725 from zanzaben/fix724_Rename_UT_ClearForceFail
436e1ea 
Fix #724, #722, rename ut clear force fail
@astrogeco astrogeco mentioned this issue Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

@CDKnightNASA CDKnightNASA

Labels
docs enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
3 participants
@zanzaben @CDKnightNASA @astrogeco