Fix #429, OS_time_t with single tick counter #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
CCB:Ready
|
CCB:2021-01-13 APPROVED @ejtimmon please comment on App impact |
astrogeco
added
CCB:2021-01-13
and removed
CCB:Ready
Use a single 64-bit tick counter as OS_time_t, rather than a split 32 bit seconds + 32 bit microseconds counter. This benefits in several ways: - increases the timing precision by 10x (0.1us ticks) - increases the representable range by 400x (+/-14000 yrs) - simplifies addition/subtraction (no carry over) - avoids "year 2038" bug w/32-bit timestamps
jphickey
force-pushed
the
fix-429-expand-ostimet-part2
branch
from
6a2ebed
to
7e34a2c
Compare
|
Rebased to current "main" and confirmed this builds OK against the current "main" branch of cfe/psp. (i.e. dependencies resolved, everything looks OK). Also added an explicit cast to This should be ready to go now. |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 25, 2021
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
…nators Fix nasa#735, add comment if null terminated or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Use a single 64-bit tick counter to implement
OS_time_t, rather than a split 32 bit seconds + 32 bit microseconds counter.This benefits in several ways:
Fixes #429
Testing performed
Build and run all unit tests, sanity check CFE
Expected behavior changes
None
System(s) tested on
Ubuntu 20.04 (native)
RTEMS 4.11 + pc686 (qemu)
Additional context
This is the final step listed in issue #429, and it depends on several dependencies being merged already:
It is submitted as a separate PR from #723 due to the dependencies, so it doesn't necessarily all have to be merged at once. However if CCB wants to accelerate the rollout this can be all done in a single merge cycle.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.