-
Notifications
You must be signed in to change notification settings - Fork 22
Update physics-based prognostic models notebook #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very small edits but this looks great and everything runs successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Added a few minor comments.
examples/04_New Models.ipynb
Outdated
"## Table of Contents\n", | ||
"* [Linear Models](#Linear-Models)\n", | ||
"* [New State Transition Models](#New-State-Transition-Models)\n", | ||
"* [Derived Parameters](#Derived-Parameters)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Organization thought. Maybe we should put all these features into a section for ease of navigation. So the sections would be:
- Linear Models
- State Transition Models
- Advanced Features - with everything there as subsections
- Simplified Battery Model Example
- Conclusion
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having an advanced features section makes sense since the subsections like derived parameters, matrix data access, state limits, custom events, and serialization all focus on optional features for the models.
I'm assuming direct models should be its own section instead of a subsection?
Co-authored-by: Christopher Teubert <christopher.a.teubert@nasa.gov> Co-authored-by: Katy Jarvis Griffith <55932920+kjjarvis@users.noreply.github.com>
5ee4a4e
to
18a8e16
Compare
Uh oh!
There was an error while loading. Please reload this page.