Skip to content

Conversation

lymichelle21
Copy link
Contributor

  • Add table of contents
  • Add labels to graphs
  • Fix formatting for consistency

Copy link

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@lymichelle21 lymichelle21 added the documentation Improvements or additions to documentation, examples, or tutorial label Apr 21, 2025
@lymichelle21 lymichelle21 marked this pull request as ready for review April 22, 2025 14:44
Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These improvements to notebook #6 look great. Here's just one question.

I see that this requires use of the dataset, so perhaps we should hold off on approval/merging until we fix the issue, just to be sure everything is running correctly. But great PR and ready to go as soon as we get the data fixed!

@lymichelle21 lymichelle21 requested a review from kjjarvis April 25, 2025 15:04
Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kjjarvis kjjarvis merged commit c635bcc into dev Apr 25, 2025
33 of 34 checks passed
@teubert teubert deleted the update-notebook-6 branch May 5, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation, examples, or tutorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants