Skip to content

Conversation

lymichelle21
Copy link
Contributor

  • Add table of contents
  • Add conclusion
  • Fix formatting for consistency
  • Label plots

Copy link

github-actions bot commented May 2, 2025

Thank you for opening this PR. Each PR into dev requires a code review. For the code review, look at the following:

  • Reviewer (someone other than author) should look for bugs, efficiency, readability, testing, and coverage in examples (if relevant).
  • Ensure that each PR adding a new feature should include a test verifying that feature.
  • All errors from static analysis must be resolved.
  • Review the test coverage reports (if there is a change) - will be added as comment on PR if there is a change
  • Review the software benchmarking results (if there is a change) - will be added as comment on PR
  • Any added dependencies are included in requirements.txt, setup.py, and dev_guide.rst (this document)
  • All warnings from static analysis must be reviewed and resolved - if deemed appropriate.

@lymichelle21 lymichelle21 added the documentation Improvements or additions to documentation, examples, or tutorial label May 2, 2025
@lymichelle21 lymichelle21 requested review from kjjarvis and teubert and removed request for kjjarvis May 2, 2025 20:19
@lymichelle21 lymichelle21 marked this pull request as ready for review May 2, 2025 20:19
Copy link
Contributor

@kjjarvis kjjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny typo here too but it looks good and everything runs!

Co-authored-by: Katy Jarvis Griffith <55932920+kjjarvis@users.noreply.github.com>
@teubert teubert merged commit ad65264 into dev May 5, 2025
33 checks passed
@teubert teubert deleted the update-prognostic-example-notebook branch May 5, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation, examples, or tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants