Clarify options #11
Merged
Clarify options #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 9987ee2 on clarify_options into * on master*. |
| @@ -22,12 +20,23 @@ def results | |||
| @results ||= run | |||
| end | |||
|
|
|||
| def options | |||
| search_methods.reduce({}) { |hash, method_name| | |||
| option_name = method_name.sub(/\Asearch_/, '') | |||
There was a problem hiding this comment.
I would have made a search_attributes method that looks something like:
def search_attributes
search_methods.map { |method_name| method_name.sub(/\Asearch_/, '').to_sym }
end
|
suggested a small refactor, but looks good |
|
Changes Unknown when pulling 41dded2 on clarify_options into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamhunter does this look good to you?