Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update mdi/angular-material dependency came with breaking changes #1762

Closed
SuperITMan opened this issue Mar 24, 2020 · 3 comments · Fixed by #1825
Closed

ui: update mdi/angular-material dependency came with breaking changes #1762

SuperITMan opened this issue Mar 24, 2020 · 3 comments · Fixed by #1825

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[X] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Due to upgrade of @mdi/angular-material dependency #1706 some icon names changed and it breaks applications.

ie: github-circle has been renamed to github Templarian/MaterialDesign#4823

image

Expected behavior

This change should be communicated with teams using Stark 10 and should be documented somewhere.

The full list of changes is available on Templarian/MaterialDesign#4901

What is the motivation / use case for changing the behavior?

Communication / Fix Showcase

@christophercr
Copy link
Collaborator

christophercr commented Mar 25, 2020

@SuperITMan another solution would be to simply revert this change and stick to the 4.9.xxx version cause this was just merged in Stark after the 10.0.0 release.

For me both solutions are fine

@SuperITMan
Copy link
Member Author

@christophercr I thought this change was included in the release 10.0.0.
Since it is not the case, I think you're right. We should revert this change and maybe keep it for the next major release 😊 (Angular 8).
Like this, we can add the necessary information in the CHANGELOG

@SuperITMan
Copy link
Member Author

Btw, after investing a bit more, I found the official CHANGELOG: https://dev.materialdesignicons.com/changelog
Good to know for the next updates

SuperITMan referenced this issue in SuperITMan/stark Apr 10, 2020
@christophercr christophercr moved this from To do to In progress in 10.1.0 Apr 13, 2020
@christophercr christophercr moved this from In progress to Review in progress in 10.1.0 Apr 13, 2020
SuperITMan referenced this issue in SuperITMan/stark Jul 24, 2020
10.1.0 automation moved this from Review in progress to Done Jul 24, 2020
SuperITMan referenced this issue in SuperITMan/stark Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
10.1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants