Skip to content

Fix ListView component #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2018
Merged

Fix ListView component #2

merged 2 commits into from
Feb 18, 2018

Conversation

EddyVerbruggen
Copy link
Contributor

  • Need to use v-template.
  • Show how to use Objects as items.

@EddyVerbruggen
- Need to use 'v-template'
7831b9f 
- Show how to use Objects as items
@rigor789
Copy link
Member

Hey, this needs a few more changes, the recommended way to use the list view is to assign the for attribute like this: <ListView for="item in items"> and in that case the scope in not required in the <v-template> (ref: https://nativescript-vue.org/en/docs/elements/components/list-view/)

I can make these changes, just let me know :)

@EddyVerbruggen
Copy link
Contributor Author

Thank you! I'll take care of it.

@EddyVerbruggen
Feedback from Igor:
00562e1 
- Use `for`
- Remove `scope`
@rigor789 rigor789 merged commit 2a23db5 into nativescript-vue:master Feb 18, 2018
@rigor789
Copy link
Member

Ignore the CI, it's borked, on my todo list to fix it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EddyVerbruggen @rigor789