Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print configuration file used in startup banner #1451

Closed
kozlovic opened this issue Jun 4, 2020 · 2 comments · Fixed by #1473
Closed

Print configuration file used in startup banner #1451

kozlovic opened this issue Jun 4, 2020 · 2 comments · Fixed by #1473

Comments

@kozlovic
Copy link
Member

kozlovic commented Jun 4, 2020

Feature Request

Report the name of the configuration file being loaded by the server.

Use Case:

One of the docker image is incorrectly not using the provided configuration file by default.
Having the config file being used printed would have helped users notice this issue faster.
See nats-io/nats-docker#36

Proposed Change:

If a configuration file is specified, print it in the banner.

Who Benefits From The Change(s)?

People deploying a NATS Server and want to make sure that proper configuration file is being used.

Alternative Approaches

N/A

@rmoriz
Copy link

rmoriz commented Jun 12, 2020 via email

@kozlovic
Copy link
Member Author

@rmoriz Knowing that from now on we would print if a configuration file is used, would not the absence of the statement in the log be enough?
That being said, I can certainly what you suggest, except that it should probably be simply" No configuration file provided", because you can still provide configuration through command line parameters, so it is not "using default configuration".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants