Add in leader elected and lost quorum advisories. #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
Note that quorum lost only fires if the old leader steps down. If the leader itself fails and that causes the loss of quorum currently no advisory is sent. Signed-off-by: Derek Collison <derek@nats.io>
ripienaar
approved these changes
Jan 28, 2021
server/jetstream_cluster.go
Outdated
| Time: time.Now().UTC(), | ||
| }, | ||
| Stream: stream, | ||
| State: mset.State(), |
There was a problem hiding this comment.
without consumer state i wonder if its worth having this really? I am not sure what I'll do with this info if I had it, what did you have in mind as a usecase?
There was a problem hiding this comment.
What would you do with state here?
There was a problem hiding this comment.
I can't think of anything I'd do with it :)
|
FYI this approach is a bit more fragile than I want, requires old leader to not be the one lost to lose quorum. Have an idea I am going to try to make it more robust. Will update PR if it works. |
We will now alert when the old leader detects a lost quorum just as before, but also detect if a candidate is flapping and failing to get votes because of no quorum. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @nats-io/core