Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[added] support for jwt operator option DisallowBearerToken #3091

Merged
merged 2 commits into from
May 4, 2022

Conversation

matthiashanel
Copy link
Contributor

@matthiashanel matthiashanel commented Apr 29, 2022

I modified an existing data structure that held a similar attribute already.
Instead this data structure references the claim.

change 3 out of 3. Fixes #3084
corresponds to:
nats-io/jwt#177
nats-io/nsc#495

Signed-off-by: Matthias Hanel mh@synadia.com

I modified an existing data structure that held a similar attribute already.
Instead this data structure references the claim.

change 3 out of 3. Fixes #3084
corresponds to:
nats-io/jwt#177
nats-io/nsc#495

Signed-off-by: Matthias Hanel <mh@synadia.com>
@matthiashanel matthiashanel marked this pull request as ready for review April 29, 2022 22:24
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but suggested added a comment that isTrustedIssuer returns if bearer token are allowed or not?

server/jwt_test.go Outdated Show resolved Hide resolved
server/server.go Show resolved Hide resolved
Signed-off-by: Matthias Hanel <mh@synadia.com>
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 12dd727 into main May 4, 2022
@kozlovic kozlovic deleted the DisallowBearerToken branch May 4, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account Policy to Restrict Bearer Token Users
2 participants