[FIXED] JetStream Store fixes and speedups. #3910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version avoids all disk IO in the filestore version. Signed-off-by: Derek Collison <derek@nats.io>
wallyqs
reviewed
Feb 26, 2023
Optimized and fixed a bug in filestore filteredPending(). Optimized memstore FilteredState(). Added comprehensive tests for NumPending() and FilteredState(). Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
store-speedups
branch
from
85d4545
to
daacbf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optimized store NumPending() call.
Optimized and simplified fileteredPending() which also fixed a bug.
Optimized memstore FilteredState().
Added comprehensive tests for NumPending() and FilteredState().
Signed-off-by: Derek Collison derek@nats.io