Send shutdown event on LDM #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he LDM node Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/r1ldm
branch
from
95da6e6
to
2364b15
Compare
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/r1ldm
branch
from
2364b15
to
d720a69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we send an event when entering lame duck mode, other nodes will mark the server as offline immediately, therefore R1 assets will not be placed onto that node. This is not a problem with R3 or higher because an LDM server operates as a Raft observer only and therefore cannot take the leadership role from an election, but R1 assets can in theory be placed onto any node that is not marked as offline.
A final shutdown event will still be sent when the server actually shuts down so there is no change there.
Signed-off-by: Neil Twigg neil@nats.io