Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Check for checksum violations for all records and before any sequence processing. #4465

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

derekcollison
Copy link
Member

Also small bug fix for leaking fds under certain scenarios during corruption.

Signed-off-by: Derek Collison derek@nats.io

@derekcollison derekcollison requested a review from a team as a code owner August 31, 2023 19:22
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison changed the title [FIXED] Fix for test and small tweak to not set last to corrupted sequence. [FIXED] Check for checksum violations for all records and before any sequence processing. Aug 31, 2023
server/filestore.go Outdated Show resolved Hide resolved
…cessing.

Also fix for bitrot test and a small bug fix for a leaking fd.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit d7ea3b9 into main Aug 31, 2023
1 of 2 checks passed
@derekcollison derekcollison deleted the bitrot branch August 31, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants